CVE-2023-46247

Dashboard / Vulnerabilities / CVE-2023-46247

CVE-2023-46247

Summary: Vyper has incorrect storage layout for contracts containing large arrays

Details: Vyper is a Pythonic Smart Contract Language for the Ethereum Virtual Machine (EVM). Contracts containing large arrays might underallocate the number of slots they need by 1. Prior to v0.3.8, the calculation to determine how many slots a storage variable needed used `math.ceil(type_.size_in_bytes / 32)`. The intermediate floating point step can produce a rounding error if there are enough bits set in the IEEE-754 mantissa. Roughly speaking, if `type_.size_in_bytes` is large (> 2**46), and slightly less than a power of 2, the calculation can overestimate how many slots are needed by 1. If `type_.size_in_bytes` is slightly more than a power of 2, the calculation can underestimate how many slots are needed by 1. This issue is patched in version 0.3.8.

References: https://github.com/vyperlang/vyper/blob/6020b8bbf66b062d299d87bc7e4eddc4c9d1c157/vyper/semantics/validation/data_positions.py#L197, https://github.com/CVEProject/cvelistV5/tree/main/cves/2023/46xxx/CVE-2023-46247.json, https://github.com/vyperlang/vyper/security/advisories/GHSA-6m97-7527-mh74, https://nvd.nist.gov/vuln/detail/CVE-2023-46247, https://github.com/vyperlang/vyper/commit/0bb7203b584e771b23536ba065a6efda457161bb