GHSA-c33x-vcv4-vg3g

Dashboard / Vulnerabilities / GHSA-c33x-vcv4-vg3g

GHSA-c33x-vcv4-vg3g

Summary: Cedar: JSON template is in scope missing slot-id validation allows link panic and decision divergence

Details: Cedar users must be using all of the following features to be affected by this advisory: JSON format policies, policy templates, and the `is in` scope condition. This advisory only affects JSON-formatted Cedar policy templates containing `is in` scope conditions that are **malformed** according to the Cedar syntax. It does **not** affect syntactically well-formed policies. Users of Cedar who author policies in the JSON format were able to write Cedar policies using the `is in` condition with an incorrect slot identifier in the principal and resource scope constraints (e.g., `?principal` in the resource scope constraint) even though this is not allowed when parsing policies from the Cedar policy syntax. Internally, the slot identifiers were silently corrected (e.g. `?resource` is placed in the resource scope constraint). If the policy contains *exactly one slot* in either the principal or resource position, then any attempt to create a linked policy from the template results in an error: the internal representation of the template does not contain the slot identifier as written in the malformed JSON policy (it has been corrected silently), so attempting to fill that slot is an error. If instead the template is linked using slot identifier expected internally (i.e., not what is written in the JSON template), the linking will initially succeed, but a subsequent invariant violation will cause a panic. When the template contains *slots in both the principal and resource* position, then both slots will be present in the internal representation: linking succeeds, but with each slot bound to the value intended for the other (the silent correction). The linked policy is then semantically different from the malformed policy the user intended, and any subsequent authorization decision made against that policy may lead to accesses being unintentionally allowed or denied. Concretely, consider the following JSON format policy template intended to deny users in a particular project from accessing documents with a particular classification. ``` { "effect": "forbid", "principal": { "op": "is", "entity_type": "User", "in": { "slot": "?resource" } }, "action": { "op": "All" }, "resource": { "op": "is", "entity_type": "Doc", "in": { "slot": "?principal" } }, "conditions": [] } ``` Linked with `?principal = Classification::"topsecret"` and `?resource = Project::"alpha"`, the author expects to create the policy: ``` forbid(principal is User in Project::"alpha", action, resource is Doc in Classification::"topsecret"); ``` But because Cedar internally links slots by scope position (not by name), the actual policy evaluated by the engine is: ``` forbid(principal is User in Classification::"topsecret", action, resource is Doc in Project::"alpha"); ``` If a user is in `Project::"alpha"` but not `Classification::"topsecret"`, the `forbid` policy does not apply, and access is unintentionally allowed. ## Patches This advisory is patched in version 4.11.1 and 3.4.3, both available on Crates.io and NPM. ## Workarounds If you cannot update to a patched version, you can determine if you are affected by checking your JSON format policy templates for the following two patterns. ``` "principal": { "op": "is", "entity_type": "User", "in": { "slot": "?resource" } } ``` and ``` "resource": { "op": "is", "entity_type": "Doc", "in": { "slot": "?principal" } } ``` ## References * [Cedar Policy Language Reference Guide - Cedar Policy Templates](https://docs.cedarpolicy.com/policies/templates.html) * [Cedar Policy Language Reference Guide - JSON Policy Format](https://docs.cedarpolicy.com/policies/json-format.html)

References: https://github.com/cedar-policy/cedar/security/advisories/GHSA-c33x-vcv4-vg3g, https://github.com/cedar-policy/cedar