GHSA-qjmq-8hjr-qcv6

Dashboard / Vulnerabilities / GHSA-qjmq-8hjr-qcv6

GHSA-qjmq-8hjr-qcv6

Summary: SQL Injection when creating an application with Reactive SQL backend

Details: ### Impact SQL Injection vulnerability in entities for applications generated with the option "reactive with Spring WebFlux" enabled and an SQL database using r2dbc. Applications created without "reactive with Spring WebFlux" and applications with NoSQL databases are not affected. If you have generated a microservice Gateway using the affected version, you might be impacted as Gateways are reactive by default. Currently, SQL injection is possible in the `findAllBy(Pageable pageable, Criteria criteria)` method of an entity repository class generated in these applications as the where clause using Criteria for queries are not sanitized and user input is passed on as it is by the criteria. ## Impacted applications - Monolith and microservice applications with SQL database and reactive with Spring WebFlux combination (other combinations are not affected and the issue is only present when you generate entities) - Gateway applications with SQL database (issue will appear only when generating entities) ### Patches Patched in v7.8.1 The `findAllBy(Pageable pageable, Criteria criteria)` method has been removed from the entity repositories and `org.springframework.data.relational.core.query.Criteria` support in the underlying methods has been replaced with `org.springframework.data.relational.core.sql.Condition`. This means you won't be able to do custom filtering in the generated applications. If you have existing reactive applications generated by the impacted version, we advise you to audit for use of `Criteria` and take appropriate actions. ### Workarounds The problem lies in the `EntityManager.java` class when creating the where clause via `Conditions.just(criteria.toString())`. `just` accepts the literal string provided. Criteria's `toString` method returns a plain string and this combination is vulnerable to sql injection as the string is not sanitized and will contain whatever used passed as input using any plain SQL So be careful when combining criterias and conditions. As a workaround we have removed the possibility to pass any user-provided criteria to the `createSelect` method of `EntityManager`. ### Example ```java Criteria criteria = Criteria.where("name").is("foobar';DROP TABLE example;--"); // parameter is user provided input criteria.toString(); // --> "'foobar';DROP TABLE example;--'" ``` ### References [More details in this Issue report](https://github.com/jhipster/generator-jhipster/issues/18269) ### For more information If you have any questions or comments about this advisory: * Open an issue in [JHipster issue tracker](https://github.com/jhipster/generator-jhipster/issues)

References: https://github.com/jhipster/generator-jhipster/security/advisories/GHSA-qjmq-8hjr-qcv6, https://nvd.nist.gov/vuln/detail/CVE-2022-24815, https://github.com/jhipster/generator-jhipster/issues/18269, https://github.com/jhipster/generator-jhipster/commit/c220a210fd7742c53eea72bd5fadbb96220faa98, https://github.com/jhipster/generator-jhipster