GHSA-rcqf-f6h2-ccg9

Dashboard / Vulnerabilities / GHSA-rcqf-f6h2-ccg9

GHSA-rcqf-f6h2-ccg9

Summary: Highcharts Dashboards parses sidebar component labels as HTML

Details: ### Impact The component language strings shown in the edit mode sidebar are parsed as HTML rather than inserted as text. An attacker who controls those language options can supply markup carrying event handlers, which execute in the origin of the page hosting the dashboard once the sidebar renders the affected labels. Exploitation requires that untrusted data reach the Dashboards language configuration and that a user open the edit mode sidebar. ### Workarounds Until you can upgrade, patch `EditMode` once at application startup. The hook runs before the sidebar is built, so the labels are already harmless by the time they are rendered. Assigning a string to `textContent` and reading back `innerHTML` turns any markup into literal text, which is exactly what the fixed version renders. After importing the module, use this code snipped once, before any board is created. ```js { const EditMode = window.Dashboards?.EditMode; const escapeHTML = (text) => text .replace(/&/g, '&amp;') .replace(/</g, '&lt;') .replace(/>/g, '&gt;'); const patched = new WeakSet(); const originalInit = EditMode.prototype.init; EditMode.prototype.init = function (...args) { const labels = this.lang?.sidebar; if (labels && !patched.has(this)) { patched.add(this); for (const key of Object.keys(labels)) { if (typeof labels[key] === 'string') { labels[key] = escapeHTML(labels[key]); } } } return originalInit.apply(this, args); }; } ``` If your application does not need Edit Mode, leaving it disabled (`editMode.enabled: false`) removes the exposure as well. ### Obtaining the patched version The patched releases are available from all the usual distribution channels. With npm, upgrade the affected package to the patched version listed above, for example `npm install @highcharts/[email protected]`. If you load Highcharts Dashboards from a CDN, use a versioned URL, for example `https://code.highcharts.com/dashboards/4.2.3/dashboards.js`. For more on each installation method, see the [installation guide](https://www.highcharts.com/docs/dashboards/installation).

References: https://github.com/highcharts/highcharts/security/advisories/GHSA-rcqf-f6h2-ccg9, https://github.com/highcharts/highcharts/commit/e65f8c21b9974dcccfa1c600a375d836acef4a7d, https://github.com/highcharts/highcharts, https://github.com/highcharts/highcharts/releases/tag/dashboards-v4.2.3