GHSA-rmxm-3fg6-px4f

Dashboard / Vulnerabilities / GHSA-rmxm-3fg6-px4f

GHSA-rmxm-3fg6-px4f

Summary: @hono/node-server: `serveStatic` decodes the request path a second time, leading to bypass of middleware on static paths

Details: ### Summary `serveStatic` decodes the request path a second time after Hono has already decoded it for routing. A crafted request can be routed as one path and served as another, so middleware mounted on a static prefix does not run for a file under that prefix. ### Details Hono decodes the request path once before routing. `serveStatic` decoded it again before resolving the file. With a malformed percent-encoded sequence, the first decode leaves part of the path encoded, the router matches the encoded form, and the second decode resolves the real directory. The file is still resolved inside the configured root; this is not a traversal outside it. ### Impact An unauthenticated attacker may reach static files without the middleware on their prefix running, for example an authentication check. This affects applications that mount middleware on part of the directory served by `serveStatic`. Applications that serve only public files are not affected.

References: https://github.com/honojs/node-server/security/advisories/GHSA-rmxm-3fg6-px4f, https://github.com/honojs/node-server/commit/982179278529d5673812116b042829f27794966f, https://github.com/honojs/node-server, https://github.com/honojs/node-server/releases/tag/v2.1.3