GHSA-vp88-798v-h67f

Dashboard / Vulnerabilities / GHSA-vp88-798v-h67f

GHSA-vp88-798v-h67f

Summary: rustls: ECH rejection can expose buffered application data to authenticated outer server before `ech_required` alert

Details: In rustls 0.23.44 and 0.23.45, application data that a client buffers before the handshake completes is sent to the server even when the server rejects Encrypted Client Hello (ECH). When the server rejects ECH, the client completes the handshake with the outer ClientHello and authenticates the server against the ECH config's `public_name`. At the end of the handshake, `start_traffic()` encrypts and queues any plaintext buffered by `ClientConnection::writer()`. It does this *before* checking for `EchStatus::Rejected` and queueing the `ech_required` alert. The application then receives `Error::PeerIncompatible(ServerRejectedEncryptedClientHello)`, as expected. However, the client is still expected to call `write_tls()` to send the fatal alert, and that call also sends the encrypted application data. The server decrypts the data and only then receives the alert. The ordering bug is older than 0.23.44. Before 0.23.44, the client checked the server certificate against the inner server name rather than `public_name`, so a correctly configured server failed certificate verification first and no data was sent. 0.23.44 fixed that check, which makes the ordinary rejection path reachable. # Impact Plaintext meant for the inner server, the one named in the encrypted ClientHello, goes to the client-facing server identified by `public_name`. That server is properly authenticated, so this is not an attack by an unauthenticated party. However this violates [RFC 9849](https://www.rfc-editor.org/info/rfc9849), which says the following: - Section 6.1.6: if the handshake and authentication succeed after ECH rejection, the client "MUST ... abort the connection with an "ech_required" alert **before sending any application data to the server.**" - Section 6.1.7: the certificate is checked only against `public_name`, and the connection "MUST NOT" be reported as successful to the application. rustls does report failure correctly. The problem is only that data is sent before the alert. This affects only clients that meet all of these conditions: - They use `EchMode::Enable`. GREASE ECH is not affected. - They write application data before the handshake completes. - They connect to a server that rejects their ECH config, for example because the config is stale. This is the same case where the server returns retry configs. The usual client response to rejection is to retry with the server's retry configs. In that case, the data has already gone to the outer server.

References: https://github.com/rustls/rustls/security/advisories/GHSA-vp88-798v-h67f, https://github.com/rustls/rustls/pull/3300, https://github.com/rustls/rustls/pull/3354, https://github.com/rustls/rustls/commit/2bd5c0cefabb2c5fd4100383a736d59f9671b9b4, https://github.com/rustls/rustls/commit/4de14a508fbfa2273203ec17d9dfdd0fbd29e8d1, https://github.com/rustls/rustls/commit/7dcbe4c1ae12185237d22e9197583329630a2014, https://github.com/rustls/rustls, https://github.com/rustls/rustls/releases/tag/v/0.23.46, https://rustsec.org/advisories/RUSTSEC-2026-0347.html